shore icon indicating copy to clipboard operation
shore copied to clipboard

Multiple same named stages fall under one E2E assertion

Open eyal-mor opened this issue 2 years ago • 0 comments

Pre Requisites

Description

Original Author: @dkirillov

If you have multiple stages with the same name, in the E2E test assertions you only need to define as if there's only 1 stage.

In my case, it worked in my favor, because I didn't need to write 5 (times 3) assertions for every deploy stage in the example.

It can, however, be an unpleasant surprise when the user unintentionally names stages the same and only adds one assertion. Or, it can be confusing for the user to know exactly how to add multiple assertions for same named stages what may have different outputs.

I'm not sure if this is something that we thought of and OK'ed, or if this is something we need to think of before anyone runs into it (in a good or bad way).

Steps to Reproduce

Expected behavior:

Actual behavior:

Reproduces how often:

Versions

Additional Information

eyal-mor avatar Feb 16 '23 09:02 eyal-mor