react-base-table icon indicating copy to clipboard operation
react-base-table copied to clipboard

Aria-label being passed to header

Open shaziajk opened this issue 3 years ago • 7 comments

Hi @nihgwu @jamesonhill

Is there any way to currently pass down an aria-label in the props to the table? In the current use case I have the table is being flagged for having accessibility issues as there is no programmatically associated name with the component

Thanks!

shaziajk avatar Jun 13 '22 12:06 shaziajk

@shaziajk Sorry I'm afraid there is no such way to do that, it was built when I knew nothing about a11y

nihgwu avatar Jun 13 '22 12:06 nihgwu

My company maintains a (private) fork for these things since Autodesk doesn't seem to be maintaining this anymore :(

jamesonhill avatar Jun 13 '22 12:06 jamesonhill

@jamesonhill It's always me not Autodesk maintaining this library 😢 , I planned to work on a rewrite but I don't work with data anymore, and I was busy with other stuffs, so actually there is no effort on new features, but I'd say the current version is already good enough if you need to support IE11, and it's still used in Autodesk

I'd like to know what changes you have made, probably we can do something based on what you have

nihgwu avatar Jun 13 '22 13:06 nihgwu

Ah, I see. I incorrectly assumed based on your comment & seeing no PRs merged that it was no longer maintained. The main thing we use the fork for is this fix: https://github.com/Autodesk/react-base-table/pull/334.

jamesonhill avatar Jun 13 '22 14:06 jamesonhill

OK I'll take a look at your PR and try to land it soon, sorry I missed that

nihgwu avatar Jun 13 '22 14:06 nihgwu

Thanks!

jamesonhill avatar Jun 13 '22 14:06 jamesonhill

Thank you for your replies!

shaziajk avatar Jun 13 '22 15:06 shaziajk