hig icon indicating copy to clipboard operation
hig copied to clipboard

Enable passing arbitrary props to all components

Open nfiniteset opened this issue 5 years ago • 3 comments

nfiniteset avatar Feb 28 '19 19:02 nfiniteset

Currently Typography and Button seem to be able to pass all down. Some of the other Inpust & Controls can do most, but className seems to be an issue, and that probably needs to be fixed.

For components that are a combination of other elements I think we should pass the className to the wrapper.

wmui51 avatar Jun 17 '19 16:06 wmui51

For components that are a combination of other elements I think we should pass the className to the wrapper.

@wmui51 Some components, their renders just return a HTML element (div, span, etc.) as this component's root wrapper, and currently we do not pass {...otherProps} to this root wrapper, do you think we should pass {...otherProps} as well as className?

garyps avatar Jun 18 '19 07:06 garyps

I think passing {...otherProps} might be a good idea.

wmui51 avatar Jun 18 '19 17:06 wmui51