Windows-Auto-Night-Mode
Windows-Auto-Night-Mode copied to clipboard
AutoDarkMode
Code quality: About SwitchModesPage and HotkeyPage
Description
- Limit GPU utilization to 100 (obviously it should not exceed 100 (っ °Д °;)っ).
- In non-battery mode, options related to power saving are no longer displayed (previously, SettingsCard was only disabled).
- Moved hotkeys to their own page and updated UX. #702
- Limit GPU utilization to 100 (obviously it should not exceed 100 (っ °Д °;)っ).
Is the utilization of GPU utilization readings capped at 100?
- Limit GPU utilization to 100 (obviously it should not exceed 100 (っ °Д °;)っ).
Is the utilization of GPU utilization readings capped at 100?
No. If the user has 2 GPUs installed and is using his machine as a render farm, GPU utilization can be higher than 100%, similar to how Linux and MacOs report utilization. The reason for this is that each Windows performance counter picks up a 0-100% range, and depending on how the driver handles it it can exceed that.
Code quality: Add hotkey deletion method
Description
Now we can use Esc, Backspace and Delete to clear the hotkey. At the same time, the description of the original SettingsCard is replaced, because now even if the hotkey is disabled, we can still edit it.
Screenshots
Code quality: "SwitchModes" renamed to "Conditions"
Description
Follow #955.
There's something strang about the hotkeys that are shown in the textbox. When I press Ctrl I see "Ctrl + Control". When I press Ctrl+Alt I see "Ctrl + Alt + Menu"...
A new icon for the NavMenu would be more appropriate now. Maybe a toggle switch?
There's something strang about the hotkeys that are shown in the textbox. When I press Ctrl I see "Ctrl + Control". When I press Ctrl+Alt I see "Ctrl + Alt + Menu"...
Thanks! I forgot to let some keys not return their values, and now it has been fixed.
A new icon for the NavMenu would be more appropriate now. Maybe a toggle switch?
I found a icon. Looks like "Control switching conditions (settings)"
Code quality: New Hotkeys page (Sorry to keep you waiting so long φ(*￣0￣) )
Description
- Added a new page for managing hotkeys
- Adjust the page order (NavBar item)
- Added a new page to capture new hotkeys (refer to PowerToys). Although the implementation is not very similar, ADM has its own hotkey saving method (saved in Yaml).
Supplement
- There is still some work to be done, including the correction of strings
- Using custom controls to put the Content of Dialog is because of a Bug in WinUI. Dialog in Xaml has no animation and looks abnormal
- The way to refresh the hotkey of the current page is still not good (you need to refresh the whole page, you can consider using binding or other methods)
Screenshots
- Using custom controls to put the Content of Dialog is because of a Bug in WinUI. Dialog in Xaml has no animation and looks abnormal
Would you like to clarify this?
Would you like to clarify this?
In fact, I didn't find a similar problem in WinUI's Issues (there was an Issue that lost animation, but it wasn't caused in Xaml). For comparison, you can check the dialog in ColorPickerPage.
Color Picker page Dialog
Hotkeys page Dialog
I see you reverted a few bits of my code. For a reason? or merge-issue?
It seems that there is a problem with the merger.
just curious: did you use the chat, linked in this comment for the code/design too? 🙂
That's right! But the final design is not only realized by these words, I try to refer to the design in other software.
Summary
Awaiting review, @Jay-o-Way Do you have anything to add?
Screenshots
Code quality: Force save hotkey
Description
In the original, hotkeys can only be edited when they are disabled. Although this restriction has been removed in the new version, users can choose to force saving because of some accidents.
Screenshots
- Well, that last new tooltip is very informal. What if there's another app that interferes with catching hotkeys? Doesn't a click do the exact same thing as the automatic save? Will the user be notified if something goes wrong saving the settings? Is there any feedback if the action is succesful?
- Also, the button makes it look like you need to press it before anything is saved; not as an "extra".
- Looks like I can't add any app to the block-list? It's a fixed list?
- @Armin2208 or @Spiritreader need to judge if the issue with the GPU percentage is acceptable
- Well, that last new tooltip is very informal. What if there's another app that interferes with catching hotkeys? Doesn't a click do the exact same thing as the automatic save? Will the user be notified if something goes wrong saving the settings? Is there any feedback if the action is succesful?
For interfering with the program to get the hotkey, it seems that the direct result is that any hotkey will not be displayed. Click Save to avoid the possibility of saving failure when the hotkey function is enabled. Although I have never met it, I believe that there was a reason let us don't edit hotkeys when the hotkey funcition is enabled before? )
- Also, the button makes it look like you need to press it before anything is saved; not as an "extra".
Indeed, I forgot this.
- Looks like I can't add any app to the block-list? It's a fixed list?
Block list only lists the currently running window programs, but you can join them by entering their own program names. However, there does seem to be a problem now. When entering a name, spaces will be automatically separated.
* @Armin2208 or @Spiritreader need to judge if the issue with the GPU percentage is acceptable
There is no issue with GPU percentage. The state is acceptable and good. I don't want to be like Microsoft, just capping the utilization of everything at 100% and because of this having complete meaningless numbers in Task Manager. So: GPU utilization can exceed 100%, the textbox accepts values over 100% and this is just how things work today. So no need to change here something.
Looks like I can't add any app to the block-list? It's a fixed list?
How about changing the text to: "Start typing to add running apps". Also: can't we display the list of all running apps then just clicking on the box? Or is typing necessary?
There is no issue with GPU percentage. The state is acceptable and good. I don't want to be like Microsoft, just capping the utilization of everything at 100% and because of this having complete meaningless numbers in Task Manager. So: GPU utilization can exceed 100%, the textbox accepts values over 100% and this is just how things work today. So no need to change here something.
The strange thing is that in previous versions of ADM, there was a limit to the maximum value of 100. Does the back-end support value exceed 100%?
Code quality: More visual indication
Description
Change the button text to let the user know that it is not necessary to click every time.There is a clear visual effect when saving successfully or failing.
Screenshots
How about changing the text to: "Start typing to add running apps". Also: can't we display the list of all running apps then just clicking on the box? Or is typing necessary?
We have a list that shows running programs, similar to the previous ADM. Typing is optional.
Change the button text to let the user know that it is not necessary to click every time.There is a clear visual effect when saving successfully or failing.
Actually, I think the "forced preservation" is a bit too technical. First, it's in the wrong time form. It must be "force preservation", because it did not happen before you click the button. "Forced" alreay happened. Maybe "Force save" is better. Or just "save". The button is only a backup nayways, you can add the save button at the bottom of the page as a new box of the ui, blending into the rest. Discovery is then not the greatest, but its clear and its there, not relying on a mouse hover description. Because I whish to have the Auto Dark Mode UI less technical.
There is no issue with GPU percentage. The state is acceptable and good. I don't want to be like Microsoft, just capping the utilization of everything at 100% and because of this having complete meaningless numbers in Task Manager. So: GPU utilization can exceed 100%, the textbox accepts values over 100% and this is just how things work today. So no need to change here something.
The strange thing is that in previous versions of ADM, there was a limit to the maximum value of 100. Does the back-end support value exceed 100%?
Sam already replied to that: https://github.com/AutoDarkMode/Windows-Auto-Night-Mode/pull/970#issuecomment-2917248819
Actually, I think the "forced preservation" is a bit too technical.
At first, I wanted users to think that this is an alternate option button (you don't need to use it every time).
Because I whish to have the Auto Dark Mode UI less technical.
But I also think this is a very important point. We should not make some explanations that could have been obvious obscure and complicated.
@ChenYiLins "forced" is passed tense (or "past participle"), is this intentional?