Windows-Auto-Night-Mode icon indicating copy to clipboard operation
Windows-Auto-Night-Mode copied to clipboard

Didn't fully change the app theme from light to dark

Open avi12 opened this issue 2 years ago • 4 comments

image

avi12 avatar Sep 16 '23 19:09 avi12

oh wow that looks like a windows 10 exclusive issue, we have to look into that.

Spiritreader avatar Sep 17 '23 00:09 Spiritreader

I have the same issue with Windows 11 (this is in Dark mode).

image

GasimGasimzada avatar Nov 03 '23 21:11 GasimGasimzada

I have the same issue with Windows 11 (this is in Dark mode).

image

that's a windows bug though.

Spiritreader avatar Nov 03 '23 23:11 Spiritreader

Yeah, I thought this ticket was about the colors when auto switching from light to dark, not about the app's own bug. Sorry about that.

GasimGasimzada avatar Nov 04 '23 20:11 GasimGasimzada

I have the same issue with Windows 11 (this is in Dark mode). image

that's a windows bug though.

No, if this was a Windows issue, then why, manually changing between light and dark themes this wrong colour change is absent? I created a new issue (I did not check this issue) which contains the relevant recording and snapshots. https://github.com/AutoDarkMode/Windows-Auto-Night-Mode/issues/845

HarshdeepSinghChauhan avatar May 08 '24 19:05 HarshdeepSinghChauhan

I have the same issue with Windows 11 (this is in Dark mode). image

that's a windows bug though.

No, if this was a Windows issue, then why, manually changing between light and dark themes this wrong colour change is absent? I created a new issue (I did not check this issue) which contains the relevant recording and snapshots. #845

Because, once again, we are calling a windows api to perform the theme switch.

If you call a windows api to apply a windows theme and it doesn't work, then Windows is the issue.

We know about it, it's in the list of common problems, there's nothing that can be done for the people that experience it except this:

If you have issues, check always refresh dwm in the settings.

If you want to fix it yourself, feel free to go ahead. But creating the 101st issue on it won't bring any meaningful improvement.

There was no meaningful difference found when using the cpl compared to invoking methods via CThemeManager.

Don't forget that ADM is an unofficial, unsupported hack that is actively disapproved by Microsoft.

Spiritreader avatar May 08 '24 20:05 Spiritreader

This issue here is about the Auto Dark Mode App itself not reliable switching its own theme. So we will not discuss Windows bugs and theme switching outside ADM.

@avi12 could you tell us if this issue is resolved?

Armin2208 avatar May 08 '24 20:05 Armin2208

Yes, it got resolved

On Wed, May 8, 2024 at 11:20 PM Armin Osaj @.***> wrote:

This issue here is about the Auto Dark Mode App itself not reliable switching its own theme. So we will not discuss Windows bugs and theme switching outside ADM.

@avi12 https://github.com/avi12 could you tell us if this issue is resolved?

— Reply to this email directly, view it on GitHub https://github.com/AutoDarkMode/Windows-Auto-Night-Mode/issues/772#issuecomment-2101357965, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRACFDBSTNWGV7HHV2TUSTZBKCHLAVCNFSM6AAAAAA43C4IOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRGM2TOOJWGU . You are receiving this because you were mentioned.Message ID: @.***>

avi12 avatar May 08 '24 20:05 avi12

Sweet, closing then :)

Let us know if the issue resurfaces, we've been trying to get to the bottom of this for a while for the Win10 build. There's some components that aren't always hooked to the theme switching event within our UI framework we use for Win10.

Spiritreader avatar May 08 '24 21:05 Spiritreader

I have the same issue with Windows 11 (this is in Dark mode). image

that's a windows bug though.

No, if this was a Windows issue, then why, manually changing between light and dark themes this wrong colour change is absent? I created a new issue (I did not check this issue) which contains the relevant recording and snapshots. #845

Because, once again, we are calling a windows api to perform the theme switch.

If you call a windows api to apply a windows theme and it doesn't work, then Windows is the issue.

We know about it, it's in the list of common problems, there's nothing that can be done for the people that experience it except this:

If you have issues, check always refresh dwm in the settings.

If you want to fix it yourself, feel free to go ahead. But creating the 101st issue on it won't bring any meaningful improvement.

There was no meaningful difference found when using the cpl compared to invoking methods via CThemeManager.

Don't forget that ADM is an unofficial, unsupported hack that is actively disapproved by Microsoft.

Understood. Thanks, but I did not know about the lack of official support given that it is a highly-rated app with a big disclaimer about winning the 2022 MS Store App Awards.

HarshdeepSinghChauhan avatar May 09 '24 14:05 HarshdeepSinghChauhan