Windows-Auto-Night-Mode icon indicating copy to clipboard operation
Windows-Auto-Night-Mode copied to clipboard

Only change the system theme when device is locked

Open vixalien opened this issue 2 years ago • 4 comments

Describe the enhancement or feature you'd like On Samsungs, the device will only change the system theme after it has been locked (i.e. the screen is off.) This is because switching themes while working is somehow jarring to see and so Samsung naturally wait for the screen to be off to apply the new theme.

Describe alternatives you've considered It would be nice to have that as an option in system settings like: "Wait for screen to be off before applying new theme"

Additional context However there is a problem: Window devices rarely go to sleep while Phones' screens usually timeout in 30 seconds. I think it would be better to wait for inactivity of the user (i.e. not exactly when screen is off.) like if the user hasn't been active for 1 min or if there is a screensaver on (or the dark color that appears when you're not using your PC).

vixalien avatar Nov 13 '21 08:11 vixalien

Sounds doable. The Windows API has a function where you can determine whether user inputs were made in the last x seconds.

Implementing a feature like this would also open up the opportunity to extend the switching API and properly support postponing. Currently the implementation is a little bit hacky, as only the gpu monitoring module is able to delay theme switching by straight up disabling the TimeSwitchModule.

Spiritreader avatar Nov 13 '21 09:11 Spiritreader

This is exactly what I was about to suggest too, your software should have a toggable option of "Switch Dark Mode only after user is away from the computer for 5-15 minutes". Because otherwise having to go through the Dark Mode switch in real-time, it takes a long time, and sometimes users are nearly hitting a professional deadline, and can't for the life of them be interrupted by the Windows Dark Mode switch.

Please give serious consideration to this improvement. Great software by the way!

Best regards, Carlos

carlosvsilva avatar Apr 23 '22 21:04 carlosvsilva

This is exactly what I was about to suggest too, your software should have a toggable option of "Switch Dark Mode only after user is away from the computer for 5-15 minutes". Because otherwise having to go through the Dark Mode switch in real-time, it takes a long time, and sometimes users are nearly hitting a professional deadline, and can't for the life of them be interrupted by the Windows Dark Mode switch.

Please give serious consideration to this improvement. Great software by the way!

Best regards, Carlos

Serious consideration is given, it's on the short list of new features to implement!

Spiritreader avatar Apr 24 '22 09:04 Spiritreader

available in latest beta!

Spiritreader avatar Jun 13 '22 16:06 Spiritreader