Windows-Auto-Night-Mode icon indicating copy to clipboard operation
Windows-Auto-Night-Mode copied to clipboard

backend support: more ways to switch theme

Open Armin2208 opened this issue 6 years ago • 7 comments

Switching theme...

  • [ ] when lowering screen brightness.
  • [ ] when ambient sensor detects a dark environment.
  • [x] when energy saver is on.
  • [x] when going from plugged in to on battery for laptops/mobile devices
  • [x] when pressing a keyboard shortcut.

Armin2208 avatar Jan 18 '19 18:01 Armin2208

It would be nice if the theme can change also when the wallpaper is predominantly dark or light. Like CullaX on KDE for Linux. Of course this need background task, but the windows wallpaper can be easily found in "%AppData%\Microsoft\Windows\Themes\CachedFiles".

Elia0107 avatar Jun 11 '19 07:06 Elia0107

Sounds nice, but I will not implement this. Sorry. I don't think that's necessary.

Armin2208 avatar Jun 11 '19 09:06 Armin2208

I think the background service project can be combined with #26.

When the background service is started, it would be useful to show a tray/notification icon that indicates that it's running.

Then it would also be possible to configure right click entries for switching themes there.

I'm very interested in contributing on this milestone together with @utkucanturkan. Did you already have a fixed plan on implementing a background service?

If not, we have briefly talked about this and came to the conclusion that a highly modularized approach would be very beneficial to the ability to maintain and create new background service modules.

Idea

A background service is created that also spawns a configurable tray icon. Since we already have a tray icon this way, we can also provide options like launching the interface from there

The service offers an interface that provides the ability to register and deregister modules. It would also take care of creating and destroying instances whenever necessary. Registered modules run on an interruptable timer which should prove to be very resource efficient.

Each module implements a standardized interface that exposes methods for periodically polling a module.

Spiritreader avatar Nov 29 '19 08:11 Spiritreader

@Spiritreader can we chat about that, in telegram?

Armin2208 avatar Nov 29 '19 19:11 Armin2208

Any plans to implement the brightness trigger? Say, when the brightness goes below a certain level.

skaiteo avatar Oct 11 '22 06:10 skaiteo

Any plans to implement the brightness trigger? Say, when the brightness goes below a certain level.

It's still planned but probably not anytime soon as that's a feature that needs to be implemented from scratch. There are a lot of other issues and improvements that take precedence right now. Win11 has been a major pain to integrate so far, and there are still outstanding issues that have higher priority.

Spiritreader avatar Oct 11 '22 11:10 Spiritreader

Roger that, thanks for the update!

skaiteo avatar Oct 11 '22 11:10 skaiteo