Authenticator icon indicating copy to clipboard operation
Authenticator copied to clipboard

Dark theme doesn't work in options

Open rakleed opened this issue 4 years ago • 4 comments

Describe the issue

When you enable the dark theme, the extension options remain in the light theme. I would like the dark theme to work on all pages of the extension.

Screenshot

screenshot-chrome-extensions-1627491519603

Browser

Chrome

Browser Version

92

Extension Version

6.3.2

rakleed avatar Jul 28 '21 17:07 rakleed

Hi @rakleed , thanks for your feedback. The option page only helps you to reset the extension and remove all data it stores. You should not use it unless there are some problems that blocks you to use the extension.

Could you explain the impact of the theme issue in that page?

Sneezry avatar Jul 28 '21 17:07 Sneezry

@Sneezry it would be nice if, when using the dark theme, all extension pages were adapted to the dark theme. This is usually how the dark theme is implemented in all other extensions.

rakleed avatar Jul 28 '21 17:07 rakleed

localStorage.theme is where current theme stores, and we can update options.html with that setting.

Sneezry avatar Jul 28 '21 17:07 Sneezry

This specific issue is probably a chrome bug, it should be pulling styles from Chrome due to "chrome_style": true in manifest.

mymindstorm avatar Jul 28 '21 21:07 mymindstorm