Authenticator [FIX] OTP type is ignored

Alternative proposal to - https://github.com/Authenticator-Extension/Authenticator/pull/1283

Oct 01 '24 08:10 olfek

Requesting review @Sneezry @mymindstorm

Oct 01 '24 08:10 olfek

🛎️🛎️🛎️ @Sneezry @mymindstorm

Oct 04 '24 11:10 olfek

Earliest I might have time to look at this is Sunday.

Oct 04 '24 13:10 mymindstorm

@mymindstorm How about this Sunday?

Oct 09 '24 09:10 olfek

@mymindstorm 📟📟📟

Oct 19 '24 11:10 olfek

@Sneezry could you look at this one?

Oct 21 '24 00:10 mymindstorm

@mymindstorm ...

~Can you run CI again, I've fixed the build error, we should only have prettier warnings left, which I will address once you make the decision on https://github.com/Authenticator-Extension/Authenticator/pull/1310#issuecomment-2432906853 (same problem of diff pollution applies here).~

EDIT see - https://github.com/Authenticator-Extension/Authenticator/pull/1310#issuecomment-2464889071

Oct 23 '24 18:10 olfek

@mymindstorm Can you run CI again here too?

Nov 08 '24 14:11 olfek

@mymindstorm 📣📣📣

Nov 18 '24 13:11 olfek

@Sneezry could you look at this one?

Over the past few weeks, I’ve been occupied with changes in the organizational structure at work. For the final two weeks of this year, I’ll need to be on-call 24/7. In January, I’ll take an extended break for Chinese New Year, the most important holiday in China. I plan to start addressing existing issues and pull requests in February next year.

Dec 05 '24 05:12 Sneezry

@mymindstorm @Sneezry With all due respect, a PR of this size would take no more than 30 minutes to review, 1 hour at most.

Dec 05 '24 11:12 olfek

@mymindstorm @Sneezry 🔔 🔔 🔔

Mar 13 '25 18:03 olfek