AuthMeReloaded Fix unregistered players teleport to spawn with unforced registration

Considering that I posted the same bug 4 years back (which was fixed on an old version), you should really consider that there are some servers, which do not force registration for players... since the whole test class is written only with forced registration in mind.

If you set teleportUnAuthToSpawn to true and also forceRegistration to false, unregistered players always end up at spawn, while they should not be altered by AuthMe and login like vanilla. Once you register that player it works perfectly fine.

Sep 17 '19 23:09 Kongolan

Looks fine to me. @sgdc3 – I remember in the past you were worried about checking if an auth is available too frequently. Maybe we should think about issuing a warning if registration is optional but the data source is not cached? @Kongolan – thanks for the contribution. You mention that there are no tests that test for optional registration. Feel free to add some if you like.

Sep 21 '19 19:09 ljacqu

So far I only added the tests for optional registration to make it compile. So I did not actually write a solid test code. But it's really something which is missed out all the time.

Sep 22 '19 16:09 Kongolan

Looking into this again since i was going to check for the 1.15 update... What is the codeclimate issue which needs to be fixed? Is that the reason why the pull request was not applied yet?

Dec 15 '19 22:12 Kongolan

Hmm dataSource.isAuthAvailable is a blocking call, are we shure that the teleport method is never called from the main thread?

Dec 16 '19 02:12 sgdc3