AuthMeReloaded icon indicating copy to clipboard operation
AuthMeReloaded copied to clipboard

Published 20 hours ago • verified publisher icon AuthMe

Sensitive commands [WIP]

Open sgdc3 opened this issue 5 years ago • 3 comments

Test doesn't compile, needs feedback. #1703 related

sgdc3 avatar Dec 07 '18 11:12 sgdc3

@ljacqu what do you think about that? I think that using the ConsoleFilter(LogFilterService) constructor is a bit dirty, any suggestion?

sgdc3 avatar Dec 07 '18 11:12 sgdc3

@ljacqu Could you please have again a look at this? :)

sgdc3 avatar Aug 08 '19 15:08 sgdc3

Comment https://github.com/AuthMe/AuthMeReloaded/pull/1705#discussion_r240327001 still stands, ideally we can construct all combinations of sensitive commands and keep them in a Set, rather than calling the slow command mapper on every command.

I'm also missing tests for the new LogFilterService ;)

ljacqu avatar Aug 08 '19 16:08 ljacqu