GameQ icon indicating copy to clipboard operation
GameQ copied to clipboard

Add Raknet protocol class with Minecraft Bedrock Edition protocol.

Open Austinb opened this issue 2 years ago • 9 comments

Only real game used with this. Normalize still needs tweaking.

Austinb avatar Aug 29 '22 04:08 Austinb

Coverage Status

Coverage decreased (-0.2%) to 88.373% when pulling e9bd2e7c5baa2538856013177f4d5ab58c3c149f on features/MInecraftBE_Raknet into 44e7906661ae90c68d77005f42cbbf151caea478 on v3.

coveralls avatar Aug 29 '22 04:08 coveralls

This is for #642. Needs checking of the normalize response. Might need to add a bit more testing around the whole magic query business which is just a bit odd.

Austinb avatar Aug 29 '22 04:08 Austinb

Sorry for the force push, had the wrong information for my signature. Will be fixed moving forward.

Austinb avatar Aug 29 '22 04:08 Austinb

This is for #642. Needs checking of the normalize response. Might need to add a bit more testing around the whole magic query business which is just a bit odd.

I'll test it in detail later and if there's an error I'll write something about it

Erani0 avatar Aug 29 '22 04:08 Erani0

This is for #642. Needs checking of the normalize response. Might need to add a bit more testing around the whole magic query business which is just a bit odd.

I'll test it in detail later and if there's an error I'll write something about it

Sounds good. Will finish up the testing as well once there are other tweaks that need to be made. Also, the server tests may need to be rebuilt.

Austinb avatar Aug 29 '22 04:08 Austinb

So I tested it with a couple of public servers and it seems that there are servers that do not transmit the port_ipv4 and port_ipv6 port then it comes to the following error message Warning: Undefined array key 10 in /var/www/pterodactyl/public/test/GameQ/Protocols/Raknet.php on line 156

Warning: Undefined array key 11 in /var/www/pterodactyl/public/test/GameQ/Protocols/Raknet.php on line 157

And on none of the tested servers the player list can be displayed. Maybe this can be changed.

Erani0 avatar Aug 30 '22 01:08 Erani0

So I tested it with a couple of public servers and it seems that there are servers that do not transmit the port_ipv4 and port_ipv6 port then it comes to the following error message Warning: Undefined array key 10 in /var/www/pterodactyl/public/test/GameQ/Protocols/Raknet.php on line 156

Warning: Undefined array key 11 in /var/www/pterodactyl/public/test/GameQ/Protocols/Raknet.php on line 157

Please send the IP addresses and ports for those servers so I can add them as tests. Need to make sure this class does not emit any kind of warnings/notices.

And on none of the tested servers the player list can be displayed. Maybe this can be changed.

Please check the Raknet protocol documents - the link is in the header of the Raknet.php file. There is no information on gathering player information other than current and maximum player counts.

Austinb avatar Aug 30 '22 02:08 Austinb

this is a public Bedrock server with 15K+ Player 151.80.79.246:19132

to test I have the following now in it so that no error is displayed

        $result->add('port_ipv4', isset($info[10]) ? (int)$info[10] : 0);
        $result->add('port_ipv6', isset($info[11]) ? (int)$info[11] : 0);

Erani0 avatar Aug 30 '22 02:08 Erani0

The inspection completed: 4 updated code elements

scrutinizer-notifier avatar Aug 30 '22 21:08 scrutinizer-notifier