Modified to show the FiveM player list

[Erani0]

A small change to the script to get the FiveM player list and display it with

[coveralls]

Coverage increased (+4.2%) to 92.685% when pulling ebe1ccb7719c8b403441e9a99bd4e70f82f7261a on Erani0:FiveM-Player-List into 44e7906661ae90c68d77005f42cbbf151caea478 on Austinb:v3.

[Erani0]

Sorry about the force push thought it was better than dozens of commits. I'm really clueless why scrutinizer always outputs an error does anyone know how to fix it so that there are no problems

[Erani0]

Finally scrutinizer has no more errors.

[Austinb]

Please remove any comments that are not needed (i.e. preventing test code from operating).

Also, as a bigger discussion, this library was built to only use the bare minimum of requirements due to hosting and other restrictions. That being said I know some hosts will block functions to prevent abuse and other issues. The question is should an internal call to \Protocols\Http (https://github.com/Austinb/GameQ/blob/v3/src/GameQ/Protocols/Http.php) be used instead of making direct calls to file_get_contents()? This is just a thought since this solution is a shoehorn option given that the protocol this game server is using does not return the player information in a "regular" query call.

Thoughts? CC: @bumbummen99

[Erani0]

So the comments were already there before but it can also be removed. And yes I understand what you mean. But FiveM outputs data differently, you can query them via http then you would have to query 2 urls and evaluate or as it is now and subsequently integrate the player list as I have done now.

[bumbummen99]

Please remove any comments that are not needed (i.e. preventing test code from operating).

Also, as a bigger discussion, this library was built to only use the bare minimum of requirements due to hosting and other restrictions. That being said I know some hosts will block functions to prevent abuse and other issues. The question is should an internal call to \Protocols\Http (https://github.com/Austinb/GameQ/blob/v3/src/GameQ/Protocols/Http.php) be used instead of making direct calls to file_get_contents()? This is just a thought since this solution is a shoehorn option given that the protocol this game server is using does not return the player information in a "regular" query call.

Thoughts? CC: @bumbummen99

How would that internal call look like?

[Erani0]

You get this information from the server. http://45.131.108.130:30120/info.json

[scrutinizer-notifier]

The inspection completed: 1 new issues, 6 updated code elements