GameQ
GameQ copied to clipboard
Add test for permanent server
Coverage decreased (-6.8%) to 87.918% when pulling 0bac556cbcd7526bf7df1188e03def4584de84b5 on dns-mocking into 01700eac12da8729f9ca0561e4c07900df33287b on v3.
Originally posted by @coveralls in https://github.com/Austinb/GameQ/issues/616#issuecomment-1133941912
Tests currently, as intended, do not query any actual server. We should also query an actual server that is kinda permanent or run the associated codepaths in some other way.
It might be best practice to actually install and start a server right in our CI, that way we do not rely on any uncontrollable factors.
Circling back to this the only real way to do this for every test set is to spin up a fake server that responds with the data from the test sets. Trying to spin up an actual game server for each game would be time consuming and full of issue in the long term. The only benefit to doing this is to be able to test the actual query classes making remote calls. Not sure we need to do this for all game types just a few common ones within A2S.