gov-au-ui-kit icon indicating copy to clipboard operation
gov-au-ui-kit copied to clipboard

Published 20 hours ago • verified publisher icon AusDTO

More obvious button states

Open DJMyles opened this issue 8 years ago • 10 comments

Seeks to address https://github.com/AusDTO/gov-au-ui-kit/issues/391

Could potentially expand from here but this is is a good start.

I used a negative offset so as to not affect the overall element size as it could affect surrounding elements if used say inline as part of an input group.

screen shot 2017-01-13 at 12 48 25 pm

Definition of Done

  • [ ] Content/documentation reviewed by Julian or someone in the Content Team
  • [ ] UX reviewed by Gary or someone the Design team
  • [ ] Code reviewed by one of the core developers
  • [ ] Acceptance Testing
  • [ ] Stakeholder/PO review
  • [ ] CHANGELOG updated

DJMyles avatar Jan 13 '17 01:01 DJMyles

I think this should be visually approved, not just PR'ed.

elisechant avatar Jan 13 '17 02:01 elisechant

@elisechant Yup, I want Gary to be across these.

klepas avatar Jan 13 '17 02:01 klepas

can I suggest that on the 'disabled' button, we use the lightest text colour possible that is still 4.5:1 contrast, eg maybe #404040 or lighter

AndrewArch avatar Jan 13 '17 02:01 AndrewArch

Any chance of seeing a live working demo?

gazhands avatar Jan 16 '17 01:01 gazhands

@gazhands I’ll deploy one after lunch for you review.

klepas avatar Jan 16 '17 01:01 klepas

@gazhands here you go: http://dg-uikit-button-offset-hover-proposal.apps.staging.digital.gov.au

klepas avatar Jan 16 '17 02:01 klepas

Thanks for the work so far everyone. I feel there's some more iteration on the visual design (of the buttons). Balancing all three states needs to be conceded (hover focus, and active) and getting these right, especially on touch screens.

gazhands avatar Jan 16 '17 03:01 gazhands

@gazhands Cool.

I feel there's some more iteration on the visual design (of the buttons). Balancing all three states needs to be conceded (hover focus, and active) and getting these right, especially on touch screens.

Could you elaborate? Does this mean we need to give this to the design clinic?

I’m happy to work any design changes into the 2.x work, so knowing what the go is re. buttons soon would be great. (:

klepas avatar Jan 16 '17 03:01 klepas

Don't mind who picks this up but design clinic is a good start. Defo keen to have it for 2.0.

gazhands avatar Jan 16 '17 04:01 gazhands

Don't mind who picks this up but design clinic is a good start. Defo keen to have it for 2.0.

*nod*

We will likely look at buttons within the coming two weeks as we write 2.x, so I propose we bring it up tomorrow.

klepas avatar Jan 16 '17 05:01 klepas