gov-au-ui-kit
gov-au-ui-kit copied to clipboard
Improvement - prefix variables with a namespace like "uikit"
It's difficult to include ui-kit in existing projects because of the collision of Sass variables which are global. To avoid collisions prefix ui-kit variables with some namespace.
ie.
$base-z-index: 0;
$base-border-radius: 3px;
$tiny-border-radius: 1px;
might be
$uikit-base-z-index: 0;
$uikit-base-border-radius: 3px;
$uikit-tiny-border-radius: 1px;
Sensible idea, I like it.
I vote for au
as the prefix; to remind us who we're making this for ;)
Great suggestion @elisechant, the only thing for us to do is decide what the prefix should be
-
$govau-uikit-
-
$govau-
-
$au-
Or something else?
FWIW from my last PR I had added $gov-ui-kit-image-base-url
for this very reason.
https://github.com/AusDTO/gov-au-ui-kit/blob/develop/assets/sass/_variables.scss#L12
Added to Jira under DESIGN-443
.