gov-au-ui-kit icon indicating copy to clipboard operation
gov-au-ui-kit copied to clipboard

Published 20 hours ago • verified publisher icon AusDTO

Feature Request - Charts

Open maxious opened this issue 8 years ago • 10 comments

https://github.com/AusDTO/d3-charts-dto ?

maxious avatar Jun 17 '16 02:06 maxious

@maxious Ditto the Calendar - what exactly is needed from us?

petronbot avatar Jun 21 '16 23:06 petronbot

This one's a bit easier - that javascript library has been made available and will probably be maintained for a while. So we just need to provide a mention in our documentation if you would like to make charts, this is available and supported internally.

maxious avatar Jun 21 '16 23:06 maxious

@maxious Excellent, issue created in the backlog, cheers.

petronbot avatar Jun 22 '16 00:06 petronbot

Would you like me to create a pull request for charts? Or are you not at a place to support that yet?

catherine-jones avatar Jul 05 '16 03:07 catherine-jones

@catherine-jones Do you have a fork/branch ready to PR? If so it would be great to have a look.

Charts is still sitting in our backlog but it's not been given high priority.

petronbot avatar Jul 05 '16 03:07 petronbot

no I don't but I could probably do it tomorrow

catherine-jones avatar Jul 05 '16 04:07 catherine-jones

If it's just some notes, you can either make a blank SCSS file or add it into README.md

maxious avatar Jul 05 '16 04:07 maxious

The README's pretty hefty already, @catherine-jones if you like I'd suggest creating a new file _charts.scss and including it in ui-kit.scss.

Then if you add comments (using one of the existing partials as a sample) you'll have content show up in the guide. You can use Markdown or HTML tags in the content to add styles or structure.

petronbot avatar Jul 05 '16 04:07 petronbot

as long as you caveat the browser support matrix

elisechant avatar Jul 12 '16 23:07 elisechant

... as well as support es6 syntax

elisechant avatar Jul 14 '16 05:07 elisechant