Aurorum

Results 25 comments of Aurorum

Yes, I think it's down to personal preference - that reasoning makes sense. :) If we're definitely set on this approach though, I think it's worth adding unit tests so...

Sorry, just noticed I committed the wrong version 🤦 This one should be good to review, and would've caught the issue. cc @oswian if that's what you had in mind....

Thanks @oswian! Totally agree a more generic test is better, and I've added your recommended proposal now. > Avoid re-implementing the useHandleClickLink logic inside the test itself. We want to...

All done! Thanks for giving these PRs a look!! :)

I'm afraid that I don't have permissions to test changes on WordPress.com Simple sites, so I'll need to leave this to others, but this is definitely strange. Presumably this might...

Not sure I agree with this. > If two or more posts have the exact same stats (e.g. a bunch of posts all have 0 visits), then the block will...

I have a couple of ideas to implement this - I'll come up with something this week.

This should be addressed in Calypso by #54691, which is reliant on Automattic/jetpack#20408.