PuzzleScriptPlus icon indicating copy to clipboard operation
PuzzleScriptPlus copied to clipboard

Some warnings get counted as errors

Open david-pfx opened this issue 2 years ago • 2 comments

At parser.js line 64, if logWarning is called without a line number, it will call logWarningNoLine, which defaults to increaseErrorCount=true. The result (and the fix) are obvious. Warnings should not increase the error count.

The fix is line 76: function logWarningNoLine(str,urgent, increaseErrorCount = true) { should be function logWarningNoLine(str,urgent, increaseErrorCount = false) {

david-pfx avatar Jul 24 '23 02:07 david-pfx

BTW it really isn't worth a PR. Hope that's enough.

david-pfx avatar Jul 24 '23 02:07 david-pfx

This bug is fixed in PS Next.

david-pfx avatar Jan 08 '24 11:01 david-pfx