Aurora.3 icon indicating copy to clipboard operation
Aurora.3 copied to clipboard

Deconstructable Shutters

Open hazelrat opened this issue 1 year ago • 6 comments

Introduces a way to deconstruct shutters with a welding torch. Takes 90 seconds in total, split into 15 seconds chunks so being pushed off the tile doesn't lose you over a minute of progress. Extends only to shutters, not blast doors.

hazelrat avatar Sep 30 '24 23:09 hazelrat

!review

hazelrat avatar Sep 30 '24 23:09 hazelrat

@FluffyGhoster Changes implemented.

hazelrat avatar Oct 05 '24 01:10 hazelrat

@Geevies Both suggestions implemented

hazelrat avatar Oct 06 '24 01:10 hazelrat

If deconstruction is added, construction if shutters need to be added aswell to allow repairs

Arrow768 avatar Oct 07 '24 21:10 Arrow768

See comment above. If deconstruction is added, construction is also required

Shutters work off buttons, which are themselves impossible to construct and are linked to their shutters with an ID variable. To do this I'd need to also allow the editing of the ID variable for shutters based on the IDs of buttons, and giving buttons a reprogrammable functionality would increase the scope of this very drastically. I can think of ways to do it, but I think it's very out of scope for this PR.

Shutters can already be constructed with an emitter, any other projectile, or with explosives. This is primarily just to make https://github.com/Aurorastation/Aurora.3/pull/19885 more palatable by allowing antagonists to be able to get through shutters without needing to use C4.

hazelrat avatar Oct 08 '24 03:10 hazelrat

See comment above. If deconstruction is added, construction is also required

Shutters work off buttons, which are themselves impossible to construct and are linked to their shutters with an ID variable. To do this I'd need to also allow the editing of the ID variable for shutters based on the IDs of buttons, and giving buttons a reprogrammable functionality would increase the scope of this very drastically. I can think of ways to do it, but I think it's very out of scope for this PR.

Shutters can already be constructed with an emitter, any other projectile, or with explosives. This is primarily just to make #19885 more palatable by allowing antagonists to be able to get through shutters without needing to use C4.

@Arrow768 With this in mind, do your required changes stand?

hazelrat avatar Oct 24 '24 10:10 hazelrat

See comment above. If deconstruction is added, construction is also required

Shutters work off buttons, which are themselves impossible to construct and are linked to their shutters with an ID variable. To do this I'd need to also allow the editing of the ID variable for shutters based on the IDs of buttons, and giving buttons a reprogrammable functionality would increase the scope of this very drastically. I can think of ways to do it, but I think it's very out of scope for this PR. Shutters can already be constructed with an emitter, any other projectile, or with explosives. This is primarily just to make #19885 more palatable by allowing antagonists to be able to get through shutters without needing to use C4.

@Arrow768 With this in mind, do your required changes stand?

Yes, the changes requires still applies, as there is imho a significant difference between setting up an emitter/using c4 to "deconstruct" shutters and actually being able to deconstruct them with just a welder.

The emitter requires a reasonable amount of time to acquire, set up properly and then break through the shutter and the C4 is a limited use item, thereby making breaking through shutters a very rare event. By just requiring a welder this is going to become a more common occurrence and as such it needs to be possible to repair the expected damage.

If you do not want to add a "full" construction mechanic due to the complexity involved (*1), an alternative would be to not fully deconstruct the shutter and instead leave behind non-functional remains, that can be repaired (instead of deleting the shutter).

*1: It could be as simple as using a multitool on a button to save the id and then applying the multitool to the shutter under construction at a certain point to set the shutter to that saved id. (or add a circuit board required to build a shutter to maintain consistency with other machinery construction where the id is encoded to in the previously described manner)

Arrow768 avatar Nov 06 '24 21:11 Arrow768