Aurora.3 icon indicating copy to clipboard operation
Aurora.3 copied to clipboard

Planes & Layers part 2: Plane Masters

Open Generalcamo opened this issue 5 months ago • 4 comments

Part 2 of the PR series to bring /tg/'s and bay's plane masters to Aurora, the lack of which is blocking several features we want.

This ports over the easier to understand Bay version of plane masters, which is detailed in the relevant readme file in the code. Example effect code for a warp effect is also in, which has been implemented for gravity catapults.

Relies on #18741

Generalcamo avatar Mar 25 '24 14:03 Generalcamo

!review

Generalcamo avatar Mar 25 '24 20:03 Generalcamo

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 01 '24 18:04 github-actions[bot]

It looks like this/the previous PR is/are so far causing these issues I noticed:

  • Space is white, lacking the icon
  • Character preview is black, without the character nor background
  • Windows are rendered above shutters
  • There's a newscaster in the middle of the central hall, D2 for some reason
  • There's also a part of it in D3, or at least it's visible through the floor
  • Air alarm in D3 too, on the other side
  • Zmimic does not seem to shade the lower layers properly
  • People seem to be masked below floorlights
  • Skrells seems to go below the railings in D2, for some reason; it doesn't seem to do that with humans - Same with the bluespace beacon outside security in D2
  • Sensors and starmap seems to have issues too, though I was only told so, so I'm not sure if it actually is true

FluffyGhoster avatar Apr 03 '24 00:04 FluffyGhoster

Sensors and starmap seems to have issues too, though I was only told so, so I'm not sure if it actually is true

Can confirm - overmap effects are layered below the overmap space turfs for some reason, meaning that navigation is effectively impossible.

This has also caused some bugs with mapping - pipes are now layered under all turfs in StrongDMM, making atmos mapping very difficult

RustingWithYou avatar Apr 03 '24 01:04 RustingWithYou