Aurora.3 icon indicating copy to clipboard operation
Aurora.3 copied to clipboard

Published 20 hours ago • verified publisher icon Aurorastation

Pocket Pouches

Open Geevies opened this issue 11 months ago • 7 comments

  • Ported pouches from CM, these are storage items that fit in your pockets. A bunch have been mapped into the cargo warehouse.

This screenshot is mostly accurate, the items on the top right rack have changed however. image

Asset Licenses

The following assets that have not been created by myself are included in this PR:

Path Original Author License
icons/obj/clothing/pouches.dmi CM-SS13 Creative Commons 3.0 BY-SA

Geevies avatar Mar 10 '24 16:03 Geevies

!review

Geevies avatar Mar 10 '24 17:03 Geevies

image

The pouches are cool, but as is I don't really see the point/purpose of these honestly:

  • If these are supposed to be standard equipment, then they should spawn in crew's lockers, equipment vendors, maybe give them these on spawn. Otherwise, why do they spawn in the warehouse? Are people supposed to go to the warehouse every shift to get these?

  • If these are not supposed to be standard equipment, then they should be orderable from cargo instead, and not be put in the warehouse.

  • In any case, the warehouse is not for like, storing gear for other jobs. Like yeah, equipment and other shit spawns there on round start, but I imagine it's all more like short-term storage before all these items are sorted and given to other departments (or sent back to CC).

DreamySkrell avatar Mar 10 '24 19:03 DreamySkrell

image This file is huge. Code for the pouches should be put in their own folder, and with different pouches types in their own files

DreamySkrell avatar Mar 10 '24 19:03 DreamySkrell

image

I do not think these fit stylistically and palette-wise on Horizon. We do not use these colors like, anywhere. At the very least these should be recolored (not necessarily resprited) to corporate colors (blue-ish/gray-ish).

There could maybe be green variants for other factions, but I think these green pouches do not fit on Horizon to be crew equipment.

DreamySkrell avatar Mar 10 '24 19:03 DreamySkrell

A few things:

  • In concept this is fine but storage absolutely needs to be nerfed as a whole if you're adding pocket pouches.
  • It needs new sprites, because CM's are totally unfitting. Sammy can probably help you with that.

NonQueueingMatt avatar Mar 18 '24 09:03 NonQueueingMatt

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Mar 28 '24 01:03 github-actions[bot]

Just going to throw this in too - instead of mapping them onto racks and such, please code them into a locker or a crate.

I also agree with Dreamy's comments.

Eyeveri avatar Mar 28 '24 15:03 Eyeveri

this one will need a little more effort and love than i'm capable of giving it right now, but if someone wants to take it over with the good feedback provided above, feel free

Geevies avatar Apr 20 '24 13:04 Geevies