Aurora.3 icon indicating copy to clipboard operation
Aurora.3 copied to clipboard

Spring Cleaning Again

Open alsoandanswer opened this issue 1 year ago • 8 comments

Same as the last one, with the fixes included

This will need to be eventually merged at a later date when convenient since this is needed as a prerequisite PR for future Skrell/Unathi events

Note : Genericisation does not apply to Konyang specific things - e.g. Korean Signs are not being translated to english.

They only apply to generic props that have a reasonable expectation of appearing on other away sites and planets, such as street lights and infrastructure objects.

alsoandanswer avatar Feb 18 '24 11:02 alsoandanswer

!review

alsoandanswer avatar Feb 18 '24 11:02 alsoandanswer

So out of curiosity, why not add the genericised versions of the props alongside their original Konyang ones?

lavillastrangiato avatar Feb 18 '24 23:02 lavillastrangiato

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 19 '24 12:02 github-actions[bot]

So out of curiosity, why not add the genericised versions of the props alongside their original Konyang ones?

I'm fine with adding them alongside the original Konyang ones. It's just that certain ones have to be changed in order to fit alongside the rest in their new files - namely, to fit the spritesheet sizes and fixing some issues. Mostly minor changes - here are some examples.

Traffic crossing. Original on left, tweaked on right. image

Street Lamp. Changed because it literally is the desk lamp on a pole. dreammaker_x7IS1MjOyr

alsoandanswer avatar Feb 20 '24 04:02 alsoandanswer

StrongDMM_fRWYyN463w StrongDMM_SFD31HhXB9 StrongDMM_wXXaCwH5i4

alsoandanswer avatar Feb 20 '24 05:02 alsoandanswer

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 20 '24 11:02 github-actions[bot]

As long as it's merged after the arc, I'm ok with it.

Leroyengloys avatar Feb 21 '24 12:02 Leroyengloys

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 22 '24 20:02 github-actions[bot]