Aurora.3 icon indicating copy to clipboard operation
Aurora.3 copied to clipboard

deck helmets

Open Greenjoe12345 opened this issue 1 year ago • 8 comments

Adds deck helmets, which can be found in the loadout, and can be found in hanger techs lockers. These have very minor armor (also adds hazard vests to hanger tech lockers) image

Asset Licenses

The following assets that have not been created by myself are included in this PR:

| Path | Original Author | License | | icons/clothing/head/deckhelmet.dmi | JoeyNosegay - Baystation12 | AGPL 3.0 |

Greenjoe12345 avatar Oct 01 '22 22:10 Greenjoe12345

!review

Greenjoe12345 avatar Oct 01 '22 22:10 Greenjoe12345

I think giving it the same resistances as the first responder's helmet would be fine. They can get those in the loadout I think and It's really nothing major. They're both plastic helmets.

CyberSpyXD avatar Oct 01 '22 23:10 CyberSpyXD

I actually didnt knew the FR helmets have any resistances. They shouldn't either, imo. In the end its probably minor and only my personal opinion.

KingOfThePing avatar Oct 05 '22 00:10 KingOfThePing

Does every hangar tech locker need 5 helmets each? That is 15 helmets, that to be honest, I barely imagine even one would be used in a round with hangar techs.

One helmet in each locker should be enough imo. Anyone who needs a specific helmet can get it from the loadout.

DreamySkrell avatar Oct 07 '22 09:10 DreamySkrell

could I get replies on the stuff I said in the requested changes?

Greenjoe12345 avatar Oct 14 '22 23:10 Greenjoe12345

could I get replies on the stuff I said in the requested changes?

Feel free to ping anyone who requests changes that you've done it/responded if there's been no check in for a while. Use the coding channel for that.

CyberSpyXD avatar Oct 19 '22 00:10 CyberSpyXD

5 (or 6) helmets is a bit overkill, even in the loadout. consider just one helmet that spawns in the OM and deck technicians' lockers, with the same colour as the operations uniforms.

I'll strip it down to one in each locker I guess then I was considering sticking some of the colored ones around on the map itself in a future PR, such as the tug operator's one by the cargo tug and the munitions one by the munitions storage, once we get that...

Greenjoe12345 avatar Oct 19 '22 23:10 Greenjoe12345

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 20 '22 17:10 github-actions[bot]

Unaddressed reviews and merge conflict since 10/20, re-open when ready

JohnWildkins avatar Dec 13 '22 14:12 JohnWildkins