Aurora.3 icon indicating copy to clipboard operation
Aurora.3 copied to clipboard

Repurposes desc_cult for desc_lore.

Open alsoandanswer opened this issue 2 years ago • 2 comments

Title. Frees up desc_fluff for snarky comments or whatever. Also macro-izes some spans.

Keep in mind I haven't touched desc_fluff or desc_lore in any capacity...yet.

That's for a future PR.

alsoandanswer avatar Sep 20 '22 13:09 alsoandanswer

Okay, I'm going to clear this up here. This is only the first piece of a larger PR, so bear with me. Basically, our current descriptions are disorganised. desc is used for shorthand descriptions, and sometimes humor desc_fluff is used for humor, detailed descriptions, and serious lore.

With this PR I'm planning to sort everything out, so : desc will be used for short/detailed descriptions, whatever appropriate desc_fluff used for humor desc_lore used for serious lore.

desc_cult i consider to be redundant, as antagonists all have inherent OOC properties anyway. Cultists are already antagonists - I didn't really see any reason to have them have an entirely seperate description section.

This was to make it atomic, so there wouldn't be a morbillion files changed from the get-go from me organising all the descriptions.

alsoandanswer avatar Sep 20 '22 16:09 alsoandanswer

!review

alsoandanswer avatar Sep 20 '22 17:09 alsoandanswer

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 18 '22 11:11 github-actions[bot]

closing as PR 14843 was merged.

SleepyGemmy avatar Nov 28 '22 22:11 SleepyGemmy