Aurora.3 icon indicating copy to clipboard operation
Aurora.3 copied to clipboard

Ports the Baystation Journalism Camera! Part 2!

Open LonelyHowls opened this issue 2 years ago • 3 comments

Heya! This is me redoing https://github.com/Aurorastation/Aurora.3/pull/14528 so that it actually works and isn't pulling from my master. I also updated the map file. I was originally going to do this all through the first PR but, uh, I screwed it up and had to refork. Lmao.

Copy of the original text here:

Hello! This PR ports the camera drone that is available on several other servers to Aurora. I'm not an especially great coder, however, and a lot of this work was handled by reverse engineering other things. I'm not totally sure if this is up to standard, but I'll make adjustments as necessary!

Things this PR does:

Ports the journalist camera from Baystation and adds a single instance of the object in the journalist's locker. The drone can broadcast video to a channel of the user's naming and broadcasts audio to the entertainment network. This device can also be built by the machinist.
Creates a News network. The network is currently only used for this. If that ends up being undesirable, I can also use the Thunderdome network since it's otherwise unused.
Allows any user to download the camera application to their modular computer of choice. This is necessary to properly implement the camera, otherwise nobody would be able to see it! By default, the only accessible camera network without an ID will be the News network.

I don't know if I did anything wrong with this - please let me know if I did! I'd like to learn how to properly do this sort of thing. I have only done, like, maybe two or three PRs in the whole of my time playing SS13. ^^;

LonelyHowls avatar Aug 11 '22 15:08 LonelyHowls

!review

LonelyHowls avatar Aug 11 '22 15:08 LonelyHowls

I also addressed Matt's original reviews in this PR! Weee.

LonelyHowls avatar Aug 11 '22 15:08 LonelyHowls

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 19 '22 23:08 github-actions[bot]

Abandoned. DM me if you need this reopened.

NonQueueingMatt avatar Nov 01 '22 12:11 NonQueueingMatt