Removes the Skills Tab From the Character Setup Screen

[SleepyGemmy]

this PR removes the skills tab from the character setup screen. the skills tab does not serve any real purpose, takes up space, and confuses new and older players from time to time.

i suspect the SQL database needs to be updated to remove the old data, but i would need help with that.

[SleepyGemmy]

!review

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Sindorman]

I have seen some people not wanting to have skills removed. I feel like this should probably have either a forums discussion or staff discussion.

[DreamySkrell]

I have seen some people not wanting to have skills removed. I feel like this should probably have either a forums discussion or staff discussion.

Commented on the other skills PR. Currently skills serve literally zero purpose and are a noob trap, so should be removed until we get mechanical skills (in which there is pretty much no interest in actually coding them in), or any other purpose.

[Sindorman]

maintainers will have the final say...

(i wonder if we have to care about getting rid of the saved preferences in SQL...)

If you never plan to bring the skill back then yes, it is taking space in the database for no reason and also increases query time which hurts the performance. It's not a lot of performance loss, but it can technically add up. Although not with aurora's player scale(you would need 1 million+ to see big difference) and caching enabled.