August Nagro

Results 54 comments of August Nagro

Great work, thanks for taking this on @lvitaly . I'm happy to merge as-is, and we can create issues & iteratively enhance from there.

One thought I have (that we can address later) is that the example app be as realistic as possible. Since TestContainers should only be used for tests, it makes sense...

We can change that by using the `ResultSet` columnLabel methods instead of columnIndex. Like [getInt(String)](https://docs.oracle.com/en/java/javase/20/docs/api/java.sql/java/sql/ResultSet.html#getInt(java.lang.String)) instead of [getInt(int)](https://docs.oracle.com/en/java/javase/20/docs/api/java.sql/java/sql/ResultSet.html#getInt(int)) Another option is to add an `@Order(int)` annotation and then put documentation...

Yep agreed. I think we will want to add `readSingle(rs: ResultSet, columnName: String): E` to DbCodec as well.

Sweet, thanks for taking it on. I am biased towards just having it all in the one DbCodec, since there are no cases where you can do one but not...

Right. If we end up going with `readSingle(rs: ResultSet, columnName: String): E` I think it's ok to throw UnsupportedOperationException for Tuples. We should also add a check in the RepoDefaults...

I agree this would be a nice feature to have. Is this what you're suggesting? ```sql CREATE TABLE order ( idA bigint not null, cents bigint not null, idB text...

I'm working on it @j-mie6 :)

Going to close, since not particularly useful in normal code.