audius-protocol icon indicating copy to clipboard operation
audius-protocol copied to clipboard

[C-4988] Update mobile TrackScreen layout for remixes + comments

Open sliptype opened this issue 1 year ago • 2 comments

Description

NOTE: I didn't put this behind a feature flag because it's semi un-related to comments. So this change will go live with next release

  • Show remix lineup on trackscreen when relevant
  • Delete TrackScreenRemixes
  • Refactor TrackScreen to use a top level VirtualizedScrollView instead of pushing everything into a single Lineup header
  • Delete TrackScreenMainContent, not really necessary anymore
  • Show cosign icon on lineup tiles and fix styling
  • Add itemsStyles to override padding of lineup items. We should think about removing the outer padding and delegating to the parent component

https://github.com/user-attachments/assets/6eb4165d-50ee-4f91-aa25-6d88c847095a

How Has This Been Tested?

Tested:

  • Tracks without remixes
  • Tracks with remixes
  • Comments feature on/off
  • Tracks with a remix parent
  • Cosign in lineup and on track screen

Need to test:

  • Android

sliptype avatar Sep 05 '24 22:09 sliptype

⚠️ No Changeset found

Latest commit: 90ba433fb66949078981ee50178acc0bc7ba91ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 05 '24 22:09 changeset-bot[bot]

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11648676 Triggered Generic High Entropy Secret 9858c5e1849c9b1929105a663236ee2ca0753add core/infra/dev_config/discovery-one.docker.env View secret
11648676 Triggered Generic High Entropy Secret 9858c5e1849c9b1929105a663236ee2ca0753add core/infra/dev_config/sandbox-one.env View secret
11648678 Triggered Generic High Entropy Secret 9858c5e1849c9b1929105a663236ee2ca0753add core/infra/dev_config/content-three.docker.env View secret
11648679 Triggered Generic High Entropy Secret 9858c5e1849c9b1929105a663236ee2ca0753add core/infra/dev_config/content-two.docker.env View secret
11648680 Triggered Generic High Entropy Secret 9858c5e1849c9b1929105a663236ee2ca0753add core/infra/dev_config/content-one.docker.env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Sep 05 '24 22:09 gitguardian[bot]