audius-protocol icon indicating copy to clipboard operation
audius-protocol copied to clipboard

Handle dupe comment thread indexing

Open isaacsolo opened this issue 1 year ago • 3 comments

Description

Handle dupe comment thread records. Only create a new one if there's not one existing already.

Handle empty metadata fields on required columns such as comment body.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Unblocked stage indexing.

isaacsolo avatar Aug 29 '24 03:08 isaacsolo

⚠️ No Changeset found

Latest commit: b94c486c3a66f7f35aff4579f4b4371fe11abe51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 29 '24 03:08 changeset-bot[bot]

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11648676 Triggered Generic High Entropy Secret 31f2712bfb22ddd6606d925839f8e54e11d918f9 core/infra/dev_config/discovery-one.docker.env View secret
11648676 Triggered Generic High Entropy Secret 31f2712bfb22ddd6606d925839f8e54e11d918f9 core/infra/dev_config/sandbox-one.env View secret
11648678 Triggered Generic High Entropy Secret 31f2712bfb22ddd6606d925839f8e54e11d918f9 core/infra/dev_config/content-three.docker.env View secret
11648679 Triggered Generic High Entropy Secret 31f2712bfb22ddd6606d925839f8e54e11d918f9 core/infra/dev_config/content-two.docker.env View secret
11648680 Triggered Generic High Entropy Secret 31f2712bfb22ddd6606d925839f8e54e11d918f9 core/infra/dev_config/content-one.docker.env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Sep 06 '24 20:09 gitguardian[bot]

I redid this PR a bit @dylanjeffers @isaacsolo feel free to take another look

DejayJD avatar Sep 06 '24 21:09 DejayJD