audius-protocol icon indicating copy to clipboard operation
audius-protocol copied to clipboard

PROTO-1775: rm tcr env

Open alecsavvy opened this issue 1 year ago • 1 comments

Description

This removes the tcr.env from the rewards bot so it can use override.env instead. This should make it compatible with audius-d. This also adds a tcr prefix to all env vars so they can be easily identified in the override.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

alecsavvy avatar Apr 16 '24 15:04 alecsavvy

⚠️ No Changeset found

Latest commit: b30997e1766f46d7a3c601c2c0d99b1405e4582f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 16 '24 15:04 changeset-bot[bot]

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
688750 Triggered Generic High Entropy Secret b30997e1766f46d7a3c601c2c0d99b1405e4582f packages/mobile/src/env/env.prod.ts View secret
1606949 Triggered Generic High Entropy Secret b30997e1766f46d7a3c601c2c0d99b1405e4582f packages/mobile/src/env/env.prod.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Apr 23 '24 16:04 gitguardian[bot]