audius-protocol icon indicating copy to clipboard operation
audius-protocol copied to clipboard

Remove legacy track + playlist indexing code

Open michellebrier opened this issue 2 years ago • 1 comments

Description

EM rolled out for tracks + playlists. Remove legacy track and playlist indexing.

Tests

Integration tests, test locally.

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

michellebrier avatar Dec 09 '22 00:12 michellebrier

thanks for doing this, looking good to me! we can get rid of users now too :)

isaacsolo avatar Jan 03 '23 17:01 isaacsolo

Some notes:

Can we keep test_index_helper.py - this has utility methods also used in the new indexing flow

I'm not sure if we still need the skip capability... the test for it is un test_index_users => test_user_indexing_skip_tx We still want the test_self_referrals in test_index_users

test_index_tracks - the track routes tests are nice to keep bc they are also used in new indexing flow - the same utility methods are used in both Same with playlist routes being tested

Maybe something for issac, but I'm not sure we need the registry address either? Not sure how the entity manager contract is deployed, or if it's via proxy.

in app.py we can remove update_discovery_provider from the beat_schedule

Also, we have to wait until we are fully on nethermind to do this change

jowlee avatar Jan 06 '23 22:01 jowlee