audius-protocol
audius-protocol copied to clipboard
[C-5579] Upgrade react router to v6
Description
Upgrades us from react-router v5 to v6. The primary goal here is to reimplement tabs using router logic and Outlets which are introduced in v6. Additionally, moving to v7 can help us improve bundle-size which im interested in as well.
I'd also like to remove the router from our redux store, which we can do safely using saga context.
⚠️ No Changeset found
Latest commit: 16a478d837c6e9d8c8608f03f260fa54d12fe7b0
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 11648676 | Triggered | Generic High Entropy Secret | 16a478d837c6e9d8c8608f03f260fa54d12fe7b0 | cmd/core/infra/dev_config/discovery-one.docker.env | View secret |
| 11648678 | Triggered | Generic High Entropy Secret | 16a478d837c6e9d8c8608f03f260fa54d12fe7b0 | cmd/core/infra/dev_config/content-three.docker.env | View secret |
| 11648679 | Triggered | Generic High Entropy Secret | 16a478d837c6e9d8c8608f03f260fa54d12fe7b0 | cmd/core/infra/dev_config/content-two.docker.env | View secret |
| 11648680 | Triggered | Generic High Entropy Secret | 16a478d837c6e9d8c8608f03f260fa54d12fe7b0 | cmd/core/infra/dev_config/content-one.docker.env | View secret |
| 9412812 | Triggered | Generic Password | 16a478d837c6e9d8c8608f03f260fa54d12fe7b0 | dev-tools/compose/docker-compose.blockchain.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.