AudiusProject
Automate tasks
Description
- Create a makefile to automate manual tasks and facilitate new users.
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
I like it but would like to have an easy way to specify the url/port for the locally running web client e.g. http://localhost:3001
Changing it in the .env was straightforward but changing it in the Makefile seems weird to me.
Also, does using a makefile restrict which environments this can be run in, like Windows?
@raymondjacobson thoughts?
I like it but would like to have an easy way to specify the url/port for the locally running web client e.g.
http://localhost:3001
Yeah, i know... can remove from makefile and expliciit this on README
Changing it in the .env was straightforward but changing it in the Makefile seems weird to me. Also, does using a makefile restrict which environments this can be run in, like Windows?
Hmm truth... i use make because is more consolidated in the unix community for build applications. Better do this in npm.scripts ?
A little search in google and get this package manager for windows. 😄
@raymondjacobson thoughts?
I like it but would like to have an easy way to specify the url/port for the locally running web client e.g.
http://localhost:3001Yeah, i know... can remove from makefile and expliciit this on README
Changing it in the .env was straightforward but changing it in the Makefile seems weird to me. Also, does using a makefile restrict which environments this can be run in, like Windows?
Hmm truth... i use make because is more consolidated in the unix community for build applications. Better do this in npm.scripts ?
A little search in google and get this package manager for windows. 😄
@raymondjacobson thoughts?
I think that shell scripts & better usage of npm scripts is a bit more portable and understandable. We've not yet introduced makefiles into the Audius ecosystem and would probably prefer some of the existing tools we have.
I like it but would like to have an easy way to specify the url/port for the locally running web client e.g.
http://localhost:3001Yeah, i know... can remove from makefile and expliciit this on README
Changing it in the .env was straightforward but changing it in the Makefile seems weird to me. Also, does using a makefile restrict which environments this can be run in, like Windows?
Hmm truth... i use make because is more consolidated in the unix community for build applications. Better do this in npm.scripts ? A little search in google and get this package manager for windows. 😄
@raymondjacobson thoughts?
I think that shell scripts & better usage of npm scripts is a bit more portable and understandable. We've not yet introduced makefiles into the Audius ecosystem and would probably prefer some of the existing tools we have.
Ok, no problem :) Let me change it for npm.scripts.