AudiusProject
[C-2778] Use EV certificate for windows signing
Description
EV cert is not ready to substitute testing keys, but this PR is good to review and those keys can be replaced before merge.
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
CI: https://app.circleci.com/pipelines/github/AudiusProject/audius-client/14879/workflows/c824c38d-8c70-41dd-bdaa-522cc20ae9ea/jobs/138212
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
CI
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.
⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 7112321 | Generic High Entropy Secret | 1c846083193af91773bb57cca36d740fd36f8d76 | packages/web/scripts/sign.js | View secret |
| 7112321 | Generic High Entropy Secret | 9f54d97ff514c0baae8db9fab4fbb8a6ea4fb44c | packages/web/scripts/sign.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
![gitguardian[bot] avatar](https://avatars.githubusercontent.com/in/46505?v=4 "Published by a pub.dev verified publisher"){kind=small}
wonderful job! are there any references or code pointers that would be worth adding for all this?
Yes added https://www.ssl.com/how-to/cloud-code-signing-integration-with-circleci/