audius-client
audius-client copied to clipboard
Consider using react-native-quick-crypto
Hey!
I noticed this repo uses react-native-crypto, which itself uses crypto-browserify under the hood. crypto-browserify is a JS-based implementation for crypto, which is slower than Margelo's react-native-quick-crypto, since this uses C++ (OpenSSL) under the hood.
If you want to replace react-native-crypto with the faster react-native-quick-crypto, I'm happy to help out or answer questions.
Hi @mrousavy great callout, and apologies for the delay. Will bring up with the team next meeting and respond back here, thanks.
From what I can tell, it looks like react-native-crypto is the default for the polyfill library we are using, called https://github.com/parshap/node-libs-react-native. Any chance you can get them to make yours the default?
I believe the main crypto piece we use is https://github.com/Crypho/react-native-scrypt, also.
@mrousavy so we are going forward with https://github.com/EdgeApp/react-native-fast-crypto since it has the scrypt
method. We are happy to use your library when https://github.com/margelo/react-native-quick-crypto/issues/126 gets addressed