audius-client icon indicating copy to clipboard operation
audius-client copied to clipboard

Consider using react-native-quick-crypto

Open mrousavy opened this issue 2 years ago • 1 comments

Hey!

I noticed this repo uses react-native-crypto, which itself uses crypto-browserify under the hood. crypto-browserify is a JS-based implementation for crypto, which is slower than Margelo's react-native-quick-crypto, since this uses C++ (OpenSSL) under the hood.

If you want to replace react-native-crypto with the faster react-native-quick-crypto, I'm happy to help out or answer questions.

mrousavy avatar Oct 06 '22 10:10 mrousavy

Hi @mrousavy great callout, and apologies for the delay. Will bring up with the team next meeting and respond back here, thanks.

From what I can tell, it looks like react-native-crypto is the default for the polyfill library we are using, called https://github.com/parshap/node-libs-react-native. Any chance you can get them to make yours the default?

I believe the main crypto piece we use is https://github.com/Crypho/react-native-scrypt, also.

dylanjeffers avatar Nov 01 '22 18:11 dylanjeffers

@mrousavy so we are going forward with https://github.com/EdgeApp/react-native-fast-crypto since it has the scrypt method. We are happy to use your library when https://github.com/margelo/react-native-quick-crypto/issues/126 gets addressed

dylanjeffers avatar Jan 13 '23 22:01 dylanjeffers