audius-client icon indicating copy to clipboard operation
audius-client copied to clipboard

Make web3 modal and audius data smaller

Open raymondjacobson opened this issue 2 years ago • 1 comments

Description

  • Move web3modal to a dynamic import
  • Remove audius data config as it is unused now Requires https://github.com/AudiusProject/audius-protocol/pull/3743

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

npm run build:prod-source-maps
npm run analyze

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

raymondjacobson avatar Aug 23 '22 02:08 raymondjacobson

Preview this change https://demo.audius.co/rj-smaller-bundle

audius-infra avatar Aug 23 '22 03:08 audius-infra

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

audius-infra avatar Mar 29 '23 19:03 audius-infra