timbral_models

timbral_models copied to clipboard

Update sklearn to scikit-learn in setup.py

1

Updated sklearn since its deprecated.

Rodsis

Deprecation of sklearn

2

Your https://github.com/AudioCommons/timbral_models/blob/master/setup.py depends on `sklearn`, which is now deprecated. The suggested fix is to use `scikit-learn` instead. Does someone have the time to try this? For some reason I get...

f-brinkmann

Update librosa calls to fix argument errors.

1

Currently the calls to `librosa` that handle onset detection breaks the `timbral_extractor(...)`. Explicitly passing arguments fixes the issue.

peacheym

onset_detect() takes 0 positional arguments but 2 were given.

4

I'm running into an error as soon as I try to run it, using the sample code given in your readme. code: import timbral_models frame = r"Downloads\Ingentia60.mp3" timbre = timbral_models.timbral_extractor(frame)...

mdruuu

This issue caused errors when processing sounds with silent segments. Because the logarithm is used to weight the samples, it is my understanding that replacing log(0) values with 0 would...

olivecha

The error occurs when there is a zero in the array : ```python spec[WR_upper_f_limit_idx:] ``` a working fix is replacing the line 217 with : ```python above_WR_spec = [value if...

olivecha

Are there any documents that explained how these features are calculated?

cryax

all_hp_centroid instead of all_hp_centroid_tpower in Timbral_Brightness.py

1

Hi, if I read the code in Timbral_Brightness.py correctly, line 125 should say: all_hp_centroid_tpower.append(hp_centroid_tpower) and line 132 should say: weighted_mean_hp_centroid = np.average(all_hp_centroid, weights=all_hp_centroid_tpower) Otherwise the hp_centroid array would contain a...

giampierosalvi

slice indices must be integers or None or have an __index__ method [in timbral_brightness and timbral_hardness]

2

When processing this sound: https://freesound.org/people/bone666138/sounds/198841/ both `timbral_brightness` and `timbral_hardness` models fail (the others work fine). Both return the same error, although it happens in different parts of the code and...

ffont

[line 253:] segment returns a empty list when a sound file has too short attack time.

3

Got the following error when I tried to compute timbral_hardness for the following sound. I suspect it's because the sound has too short attack time. http://freesound.org/people/ShawnyBoy/sounds/165394/ ERROR : line 253,...

albincorreya