Servers are unaware of the pos dropdown until next sent message
Describe the bug The position dropdown only sets position locally for the next spoken message. The server is unaware of the client pos until that point, which is really annoying when it comes to checking someone's position in /getarea or when trying to view positional evidence (such as defense/prosecution evidence, or room escape positional evidence for servers like KFO)
To reproduce Steps to reproduce the behavior:
- Join a server
- Set a pos dropdown
- Send a message
- Notice it only says "position set to "..."" once you send a message and not before.
Expected behavior Position is set as soon as the dropdown is changed
Dropdown does not send the position until you send a message. Who thought this is desirable default behaviour?
Dropdown does not send the position until you send a message. Who thought this is desirable default behaviour?
This change was deliberate. In the past, scrolling through the pos dropdown would spam the server with position change messages (which at this time were still OOC messages hardcoded to say "/pos") and this would flood the chat very quickly. This change was made by @Crystalwarrior in 2.8.
See https://github.com/AttorneyOnline/AO2-Client/issues/112#issuecomment-646814826
Well, we have a packet to set your position, so we are good to go now!
Plottwist : That packet is server only. Fuck this application. Hard. Who thought this was a sane decision.
complains about a change he made himself........... a seperate packet seems to be the best solution for this
In hindsight, maybe a dropdown list was not the best option for this kind of behavior.