AO2-Client icon indicating copy to clipboard operation
AO2-Client copied to clipboard

Servers are unaware of the pos dropdown until next sent message

Open Crystalwarrior opened this issue 2 years ago • 6 comments

Describe the bug The position dropdown only sets position locally for the next spoken message. The server is unaware of the client pos until that point, which is really annoying when it comes to checking someone's position in /getarea or when trying to view positional evidence (such as defense/prosecution evidence, or room escape positional evidence for servers like KFO)

To reproduce Steps to reproduce the behavior:

  1. Join a server
  2. Set a pos dropdown
  3. Send a message
  4. Notice it only says "position set to "..."" once you send a message and not before.

Expected behavior Position is set as soon as the dropdown is changed

Crystalwarrior avatar Jan 29 '23 19:01 Crystalwarrior

Dropdown does not send the position until you send a message. Who thought this is desirable default behaviour?

Salanto avatar Jan 30 '23 00:01 Salanto

Dropdown does not send the position until you send a message. Who thought this is desirable default behaviour?

This change was deliberate. In the past, scrolling through the pos dropdown would spam the server with position change messages (which at this time were still OOC messages hardcoded to say "/pos") and this would flood the chat very quickly. This change was made by @Crystalwarrior in 2.8.

See https://github.com/AttorneyOnline/AO2-Client/issues/112#issuecomment-646814826

in1tiate avatar Feb 04 '23 23:02 in1tiate

Well, we have a packet to set your position, so we are good to go now!

Salanto avatar Feb 04 '23 23:02 Salanto

Plottwist : That packet is server only. Fuck this application. Hard. Who thought this was a sane decision.

Salanto avatar Feb 11 '23 14:02 Salanto

complains about a change he made himself........... a seperate packet seems to be the best solution for this

stonedDiscord avatar Mar 23 '23 13:03 stonedDiscord

In hindsight, maybe a dropdown list was not the best option for this kind of behavior.

collinxchu avatar Aug 14 '24 13:08 collinxchu