AO2-Client icon indicating copy to clipboard operation
AO2-Client copied to clipboard

Emotes w/ offset are not centered in Emote Preview

Open Satoru-1816 opened this issue 3 years ago • 6 comments

Describe the bug Changing any of the offset values misaligns the selected sprite in Emote Preview. Also, if you resize the window, the emote resets back to the center. I'm 100% sure the emotes weren't affected by offset in older 2.10 builds.

To reproduce Steps to reproduce the behavior:

  1. Select any sprite and open the Emote Preview
  2. Change the offset
  3. See character misaligning
  4. Resize the window to see the character reset to center

Expected behavior Offset not affecting Emote Preview.

Screenshots

https://user-images.githubusercontent.com/81326989/183303010-f89df08d-b216-45d8-a9c7-3d94e03dd574.mp4

Version:

  • OS: Windows 10
  • Version or branch: 2.10 RC1

Satoru-1816 avatar Aug 07 '22 17:08 Satoru-1816

This is an emote preview, not an offset preview. The actual bug here is that the offset affects the preview at all.

Salanto avatar Aug 07 '22 20:08 Salanto

This is an emote preview, not an offset preview. The actual bug here is that the offset affects the preview at all.

Uh what are you talking about, the actual bug is the offset resetting from resizing the window. The offsets being represented in the preview window is intentional because it's otherwise really hard to figure out how your sprite is going to look like with just numbers.

Crystalwarrior avatar Aug 07 '22 20:08 Crystalwarrior

I gotta agree with Salanto. There's no background or anything else besides the emote being previewed, so unless you resize the window to match the exact dimensions of the IC viewport, the offset in the emote preview is kinda useless for figuring out how the sprite is actually gonna look like. The offsets just get in the way imo

Satoru-1816 avatar Aug 07 '22 21:08 Satoru-1816

Changing any of the offset values misaligns the selected sprite in Emote Preview.

This is a feature. A lot of collective time has been wasted trying to find the right offset % when pairing. Moreover, whatever is obscured due to the offset percentage will always be obscured when the emote is sent with the given parameters. I do not believe the emote preview was meant to serve only as a general image viewer.

That said, it should be possible and relatively easy to make a right-click menu to toggle offsets on the preview. (Or stick it in the settings menu along with everything else.)

oldmud0 avatar Aug 18 '22 02:08 oldmud0

I second making this an option in settings or rightclick context menu

Crystalwarrior avatar Jan 29 '23 19:01 Crystalwarrior

what piece of code handles the resizing of the preview window or is there none and this is qt default behaviour

stonedDiscord avatar Mar 27 '23 15:03 stonedDiscord