Transferring private evidence to public list always reports success, even on failure

[in1tiate]

Describe the bug When the user attempts to transfer private evidence to the public list, the server may disallow this by locking evidence changes to privileged users only. In these cases, a success is reported even though the evidence list was not changed.

To reproduce Steps to reproduce the behavior:

1. Enter an area with restricted evidence privileges
2. Create a piece of private evidence
3. Transfer evidence to the public list
4. Observe notice that transfer was successful, and verify that the public list is unchanged

Expected behavior Client should report failed transfer if public list does not contain the transferred evidence

Additional context This could have been avoided if not for the seeming assumption that all users will have evidence privileges

[Salanto]

We could either send an evidence rejection packet or check if the next incoming evidence update has the new entry. Both solutions are kinda ehhhhhhhh, but would provide the necessary feedback.

Or we add a timeout to the evidence update and utilise the QtPromise stuff in devel-2-11

[stonedDiscord]

the server should send back an updated evidence list, even when the transfer failed