ivan icon indicating copy to clipboard operation
ivan copied to clipboard

Split big classes by context.

Open AquariusPower opened this issue 7 years ago • 5 comments

Some new functionalities would be good to be put in new classes, like the WizardAutoPlay (may not grow) and Crafting/Recipes (this may grow a huge lot).

I dont know how to use friend class yet, may not be required tho.

If there is other subcontexts that could be split from bloated .cpp files, point it out :)

AquariusPower avatar Jun 12 '18 00:06 AquariusPower

My friend, perhaps you might be interested in this IVAN variant? The developer posted a thread on it here: https://attnam.com/topics/another-one-IVAN-fork?page=1

A lot of work was done to split the source files up, and there might be a few good working examples in here of useful code. This particular dev wishes to remain underground for various reasons, but is happy for his code to be reused. Worth a look : )

ryfactor avatar Jun 12 '18 00:06 ryfactor

Also good to make a keybinding system.

OT: That guy did a good feat. I like that commit message: bye-bye, autocrap and make; hello, jam! %-)

jakwings avatar Jun 12 '18 05:06 jakwings

Also good to make a keybinding system.

as I remember, Ivan3D has it right? I merged it initially but I dont know how to maintain the 3D engine to fix it further. https://github.com/AquariusPower/ivan/tree/Ivan3Dpatch

AquariusPower avatar Jun 12 '18 06:06 AquariusPower

https://github.com/AquariusPower/ivan/blob/6786fcd54eb8b308be358db58220f50236d9b1ce/Main/Source/command.cpp#L59

It has no UI yet, and doesn't resolve conflicts with look-mode commands and such.

jakwings avatar Jun 12 '18 06:06 jakwings

I see, I meant it as a quickstart :)

AquariusPower avatar Jun 12 '18 09:06 AquariusPower