atrilabs-engine icon indicating copy to clipboard operation
atrilabs-engine copied to clipboard

Add a Comments Component

Open adityaxpique opened this issue 2 years ago • 8 comments

The signature of time picker component should be as follows:-

type CommentsProps = {
       styles: React.CSSProperties;
       custom: { 
		comments: {
		       //Name of the guy commenting.
		       name: string;
		       //The time at which reply was done
		       dateTime: string;
                       //The comment text 
                       text: string;
		       replies: {
   			     // Name of the guy replying.
   			     name: string;
   			     // URL to redirect where the item will redirect.
   			     reply: string;
 		        }[];
 	       }[]
       };
};
 
export const CommentsProps: React.FC<CommentsProps> = React.forwardRef(
  (ref, props) => {
    return <div></div>;
  }
);

The design reference- 6

adityaxpique avatar Oct 08 '22 08:10 adityaxpique

Check this before contribute

corners2wall avatar Oct 08 '22 17:10 corners2wall

Bumping up this prior discussion around why we try to avoid using libraries while adding a new component to the framework: https://github.com/Atri-Labs/atrilabs-engine/discussions/216

darshitac11 avatar Oct 08 '22 18:10 darshitac11

It's not just about using the library. The link can be used as a help for contribute.

corners2wall avatar Oct 08 '22 18:10 corners2wall

Yes, of course and thanks for sharing the link.

I just wanted to clarify since our first instinct is usually to use a library - a few PRs last week had to be redone because of this reason.

darshitac11 avatar Oct 08 '22 19:10 darshitac11

@all-contributors please add @corners2wall for research

darshitac11 avatar Oct 09 '22 10:10 darshitac11

@darshitac11

I've put up a pull request to add @corners2wall! :tada:

allcontributors[bot] avatar Oct 09 '22 10:10 allcontributors[bot]

@darshitac11 mam plz assign me for this issue

Jitulteron7 avatar Oct 09 '22 21:10 Jitulteron7

@darshitac11 Can you please assign this issue to me. It would also be great if I can get some direction on how or where to get started with this as it's my first time contributing to open source. Thank you!

PrinsonF77 avatar Feb 09 '23 10:02 PrinsonF77