Atreyee Sinha

Example of a spectrally varying temporal model

6

This is a test implementation of a model with time dependent spectral variability. For now, I simply add it as a an example in our models tutorial, as a custom...

Energy evaluation of temporal model

7

This is a cleaner implementation of the PR started in #3838 The following steps are to be implemented - [x] Enable the energy evaluation - [x] Add a test -...

Safe mask functions should not rely on the projected IRFs

1

Continuing from the discussions in #3873, maybe safe mask functions should not use the binned IRFs, but rather the DL3 irfs directly when possible. This is a reminder issue for...

Add a CompoundTemporalModel

1

While working on the models tutorial, I feel that a `CompoundTemporalModel` is probably quite useful for modelling multiple flares. I can add one along the lines of `CompoundSpectralModel`. @adonath @registerrier...

Add a PeriodicMapAxis

3

This PR adds a PeriodicMapAxis. Its rather simple, only one function, so arguably it does not need its own class at all. But I think its conceptually simpler to have...

Required functionalities for AGN analysis

3

This is a preliminary list for the short term requirements for temporal analysis. Please feel free to append further points - [x] Implement asymmetric gaussian temporal model - [ ]...

Add examples in docstrings

4

It is very helpful to have an `Examples` section in the docstring of functions. Specially for `gammapy.maps` and `gammapy.estimators` where its often unclear what slices need to be passed as...

There are a couple of functions here https://github.com/gammapy/gammapy/blob/d4a6194d8c2b85fbb913d2fd4f7a99a1d3803040/gammapy/utils/time.py#L23 (time_to_fits_header, time_to_fits) that are untested and probably do not confirm to the guidelines in https://gamma-astro-data-formats.readthedocs.io/en/v0.3/general/time.html?highlight=TIMEREF#formats Reminder issue to verify and cleanup

Modify `MapAxis.downsample` to have an option strict=False option which when set to True will simply put the remainder in the last bin https://github.com/gammapy/gammapy/pull/5007#discussion_r1455938626_

As discussed in https://github.com/gammapy/gammapy/pull/5015#discussion_r1450056683_ the function `get_fov_coords` should be moved to to either `gammapy.data.pointing`, or to a new module `gammapy.coordinate` which uses astropy Frames to implement the different definitions of...