linter-glsl icon indicating copy to clipboard operation
linter-glsl copied to clipboard

Published 20 hours ago • verified publisher icon AtomLinter

[WIP]glslify support

Open fand opened this issue 7 years ago • 3 comments

It's still experimental. Please give me some advice if you are interested 😸

https://github.com/stackgl/glslify/issues/95

Changes

  • Added Use glslify to config
  • Uses forked version of glslify to generate sourcemaps

fand avatar Aug 16 '17 04:08 fand

It parses sourcemaps and shows the error line (almost) correctly.

2017-08-16 13 31 55

fand avatar Aug 16 '17 04:08 fand

This is a very interesting idea, I'm not too sure about moving forward with it here though until support is more baked into the tools behind this.

Thoughts @andystanton?

Arcanemagus avatar Aug 17 '17 23:08 Arcanemagus

@fand @Arcanemagus I think this is a fantastic idea.

As you've already discussed, the sourcemap work needs to be merged in glslify first, but then we can definitely take a look at the best way to integrate it.

I would embrace making glslify linting the default as it will work out of the box, but still give the user the option to use glslangValidator if they prefer to have official Khronos validation.

andystanton avatar Feb 13 '18 09:02 andystanton