linter-flow
linter-flow copied to clipboard
AtomLinter
fix(error-handling): Don't re-check flow for any error.
The linter used to recheck flow when the server was initializing. This could cause massive CPU usage.
fixes #114
@ericnkatz @cristian-sima @Arcanemagus Can you please take a look at this PR and see if it fixes the issue. I want to be sure because this fix has the side-effect of throwing more errors in Atom.
I don't actually use flow myself, and haven't seen this issue in the very limited testing that I've done.
@nmn I can not say if it fixes or not. I wait until it is available as an update in Atom's list of updates, then I'll install it and test it
@Arcanemagus Looks like this has solved the performance issue -> will be testing throughout the day to see if it still comes up.
@mmazzarolo The "news" is still one "maybe" that it fixes it and no other feedback, so you are the only one who can answer that question 😛.
Unfortunately this package seems to not have an active maintainer currently, I'll poke around a bit and see if there is anything I can take care of but I don't use this linter myself currently.
@Arcanemagus Got it :) I moved to nuclide right now, but I can confirm that yesterday I was still having the CPU issue.
Is this PR still relevant? Can you rebase on master and fix the requested changes so we can see if the CI builds are still failing?