atmosphere-javascript icon indicating copy to clipboard operation
atmosphere-javascript copied to clipboard

Published 20 hours ago • verified publisher icon Atmosphere

Support ES Modules

Open mjeanroy opened this issue 5 years ago • 4 comments

Hi @jfarcand,

Currently, the codebase supports AMD, commonjs and global (the UMD pattern). But, there is not support for ES Modules, so my question is: is there a plan to support it?

There are a lot of benefits by using ES Modules, such as tree shaking for example. I think that adding support for ES Modules need some changes, at least:

  • Do not rely on java yui compressor, since it does not support ES Modules.
  • Distribute both UMD package and ES packages.

If that is something that can interest you, I think I can start working on it. What do you think?

mjeanroy avatar Dec 22 '19 16:12 mjeanroy

What do you think about this @jfarcand? Everything is starting to be esm these days and some tooling even requires esm. We currently have a problem with using Atmosphere because of a @web/dev-server issue

In the world I am living in, no other distribution than ESM is needed at all but others might have different needs.

Artur- avatar Oct 13 '22 06:10 Artur-

I published an esm version as https://www.npmjs.com/package/a-atmosphere-javascript to get around this

Artur- avatar Oct 13 '22 08:10 Artur-

@Artur- Sound like I've completely missing the message from @mjeanroy. I would have say GO let's do it.

jfarcand avatar Oct 13 '22 18:10 jfarcand

@Artur- Just do a pull request and I will release it under 4.0.0, and maintain 3.1.x amd

jfarcand avatar Oct 13 '22 18:10 jfarcand