athena icon indicating copy to clipboard operation
athena copied to clipboard

util: athena-run: use tmp directory, fix filetype

Open MacroLens opened this issue 1 year ago • 1 comments

Change athena-run shell script to use the system's tmp directory rather than the ATHENA_HOME directory. Installing athena to ATHENA_HOME that is not writeable to all users, i.e. installing athena as a shared application, makes the athena-run script useless. By using the system's tmp directory you are able to write the temporary file needed without having write access to ATHENA_HOME.

Fixes a filetype issue when trying to load a .ath file with athena-run. Using athena-run with example.ath results in athena loading example.ath.ath. Which is unintended behavior.

MacroLens avatar Jan 14 '24 02:01 MacroLens

Thanks for this.

The change to using system's tmp directory will break some 3rd party tooling that uses Athena. I think a backwards compatible option, which first tries ATHENA_HOME and, upon failure, utilizes system tmp directory is therefore preferred here.

I do agree with the update to allow athena-run to accept file names regardless of whether or not the input includes the .ath extension.

WilfredTA avatar Apr 05 '24 18:04 WilfredTA