dmipy icon indicating copy to clipboard operation
dmipy copied to clipboard

check dipy compatibility

Open matteofrigo opened this issue 5 years ago • 2 comments

With the recent update of dipy, many functions will not work. There are two possible solutions:

  • Require an old version of dipy (suboptimal)
  • Do a complete revision of the parts of dmipy where dipy is used (will take longer than expected)

What do we do @rutgerfick ?

matteofrigo avatar Sep 27 '19 13:09 matteofrigo

Where are the spots you think it's broken? only median_otsu?

The python3 tests pass with dipy 1.0, so it must be something that's not in the tests.

rutgerfick avatar Oct 02 '19 08:10 rutgerfick

For sure median_otsu, but I think it will be better to go through the whole list of changed functions and just check if they are used anywhere. Although it's mostly streamlines-related functions, which makes the job much easier as they are never used in dmipy.

For the records, one case in which median_otsu is used is discussed in #76 .

matteofrigo avatar Oct 02 '19 13:10 matteofrigo