NYU-DLSP20 icon indicating copy to clipboard operation
NYU-DLSP20 copied to clipboard

[BN] Update 01.md

Open kishordgupta opened this issue 3 years ago • 8 comments

minor change

kishordgupta avatar Dec 12 '20 02:12 kishordgupta

@khalidsaifullaah, you've approved the changes, but asked to edit. I'm confused now. Is this okay for merging or are there pending edits?

Please, let me know what your review is.

Atcold avatar Dec 13 '20 22:12 Atcold

@khalidsaifullaah, you've approved the changes, but asked to edit. I'm confused now. Is this okay for merging or are there pending edits?

Please, let me know what your review is.

Really sorry @Atcold, I wasn't much aware of this "Review" system before, so it was my bad. I guess you could merge the PR after the changes are made.

khalidsaifullaah avatar Dec 14 '20 04:12 khalidsaifullaah

Don't be sorry @karanchahal. When you review the PR, you can choose "comment", "accept", or "ask for edit". Depending which one you pick you'll be sending a different message to me and the PR owner. Also, make sure people are aware of the translation guidelines. For example, this PR doesn't have a language code in the title (@kishordgupta can still edit that).

@kishordgupta, after you've pushed your edits I'll merge, if @karanchahal gives the green light.

Atcold avatar Dec 14 '20 16:12 Atcold

I have no clue what this language is @Atcold ! 🤣

karanchahal avatar Dec 14 '20 17:12 karanchahal

I have no clue what this language is @Atcold ! 🤣

I think @Atcold tagged you instead of tagging me, because of our name's initial letter I guess😄

khalidsaifullaah avatar Dec 14 '20 17:12 khalidsaifullaah

Hey guys… y'all have a k- and many letters user… 🤣🤣🤣 The message was supposed to be:

@khalidsaifullaah, don't be sorry.

@kishordgupta, after you've pushed your edits I'll merge, if @khalidsaifullaah gives the green light.

Anyhow, follow the instructions now 😛😛😛

Atcold avatar Dec 15 '20 05:12 Atcold

@khalidsaifullaah, other translators are using এ instead of "ক"

kishordgupta avatar Dec 20 '20 04:12 kishordgupta

@khalidsaifullaah, other translators are using এ instead of "ক"

Yeah, I saw that, So, I guess we're doing it that way, we're good to go then...

khalidsaifullaah avatar Dec 20 '20 05:12 khalidsaifullaah